Skip to content

Fix globals not evaluating in Grading Workspace #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2018
Merged

Fix globals not evaluating in Grading Workspace #377

merged 1 commit into from
Sep 21, 2018

Conversation

remo5000
Copy link
Contributor

No description provided.

@remo5000
Fix globals evaluation
f904e38 
(symbol, "javascript code") should be mapped to (symbol, value).
@coveralls
Copy link

Pull Request Test Coverage Report for Build 869

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.761%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/castBackend.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 865: 0.0%
Covered Lines: 903
Relevant Lines: 2965
💛 - Coveralls

rrtheonlyone
rrtheonlyone approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@rrtheonlyone rrtheonlyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@remo5000 remo5000 merged commit 152b8e2 into master Sep 21, 2018
@remo5000 remo5000 deleted the fix-globals branch September 21, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrtheonlyone rrtheonlyone rrtheonlyone approved these changes

@indocomsoft indocomsoft Awaiting requested review from indocomsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remo5000 @coveralls @rrtheonlyone