Skip to content

C4 rush #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 1, 2018
Merged

C4 rush #107

merged 6 commits into from
Nov 1, 2018

Conversation

martin-henz
Copy link
Member

No description provided.

@martin-henz
Copy link
Member Author

Ningyuan or Yuchuan: could you take a look. I think this could fix the problem with =>

@martin-henz
Copy link
Member Author

If ready, we need to deploy in NPM and bump the version number. Then Rahul can deploy in the playground.

yyc
yyc approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@yyc yyc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test for arrow functions, and fixed some import and syntax errors.

Approved conditional on the build passing.

@yyc
Copy link
Contributor

yyc commented Nov 1, 2018

@martin-henz it looks good to me but I don't have a lot of context on this so you might want @ningyuansg or kenneth to double-check.

@coveralls
Copy link

coveralls commented Nov 1, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 243

  • 10 of 35 (28.57%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 42.812%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stdlib/parser.js 8 33 24.24%
Files with Coverage Reduction New Missed Lines %
src/stdlib/parser.js 1 2.99%
Totals Coverage Status
Change from base Build 236: 0.02%
Covered Lines: 842
Relevant Lines: 1760
💛 - Coveralls

@remo5000
Copy link
Contributor

remo5000 commented Nov 1, 2018

Getting a syntax error when running on docker:
image

@yyc yyc merged commit 4dfa00f into master Nov 1, 2018
@yyc yyc mentioned this pull request Nov 1, 2018
Merged
@thomastanck thomastanck deleted the C4-rush branch December 9, 2018 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyc yyc yyc approved these changes

@remo5000 remo5000 Awaiting requested review from remo5000

@ning-y ning-y Awaiting requested review from ning-y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martin-henz @yyc @coveralls @remo5000