Skip to content

Move list visualiser to chapter 2 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Move list visualiser to chapter 2 #27

merged 2 commits into from
Aug 8, 2018

Conversation

remo5000
Copy link
Contributor

@remo5000 remo5000 commented Aug 6, 2018

No description provided.

@remo5000 remo5000 requested a review from ning-y August 6, 2018 16:15
@remo5000
Copy link
Contributor Author

remo5000 commented Aug 6, 2018

@ningyuansg Should we rename the function to visualise_list? I feel that draw is too similar to some external libraries

@coveralls
Copy link

coveralls commented Aug 6, 2018

Pull Request Test Coverage Report for Build 42

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 48.285%

Files with Coverage Reduction New Missed Lines %
src/createContext.ts 1 83.04%
Totals Coverage Status
Change from base Build 21: 0.06%
Covered Lines: 615
Relevant Lines: 1167

💛 - Coveralls

@ning-y
Copy link
Member

ning-y commented Aug 7, 2018

@remo5000 try draw_list.

@ning-y
Copy link
Member

ning-y commented Aug 8, 2018

@remo5000 Are you renaming this draw to draw_list or no?

@remo5000
Copy link
Contributor Author

remo5000 commented Aug 8, 2018

@ningyuansg Missed this out, done! I've updated the PR on the frontend as well

@ning-y ning-y merged commit cc5507a into master Aug 8, 2018
@ning-y ning-y deleted the list-visualizer branch August 8, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants