Disallow var statements #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1432
💛 - Coveralls |
thomastanck
reviewed
Jul 25, 2019
|
|
||
| checkers: { | ||
| VariableDeclaration(node: es.VariableDeclaration, ancestors: [es.Node]) { | ||
| if (node.kind === 'var') { |
There was a problem hiding this comment.
I think it might be better to have a rule to allow const and let only rather than to disallow var, and we can merge with noDeclareMutable
There was a problem hiding this comment.
Nevermind, I take this back. Not currently sane to have a whitelist using rules.
thomastanck
approved these changes
Jul 25, 2019
|
|
||
| checkers: { | ||
| VariableDeclaration(node: es.VariableDeclaration, ancestors: [es.Node]) { | ||
| if (node.kind === 'var') { |
There was a problem hiding this comment.
Nevermind, I take this back. Not currently sane to have a whitelist using rules.
|
Yeah. I wanted to combine the two also but it's not possible for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's disallow var statements and allow only const and let.