Skip to content

Add Source Week 1 as an internal reference for the Avengers #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

martin-henz
Copy link
Member

My intention is to focus the Avengers and tutors on this language in our interactions with the students, until we introduce more constructs.

@martin-henz martin-henz requested a review from ning-y August 19, 2018 05:08
@coveralls
Copy link

coveralls commented Aug 19, 2018

Pull Request Test Coverage Report for Build 65

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.188%

Totals Coverage Status
Change from base Build 57: 0.0%
Covered Lines: 624
Relevant Lines: 1185

💛 - Coveralls

Copy link
Member

@ning-y ning-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I confirm that the make all is intended to not generate a pdf for source_week_1.tex? Or perhaps you could include source_week_1.pdf as a target for make all, but exclude it from the prerequisites for make install.

@remo5000
Copy link
Contributor

Hi Prof @martin-henz, is there any update on the make all behaviour? I'd like to merge this PR once the above query is resolved

@ning-y ning-y requested a review from remo5000 August 22, 2018 10:05
@remo5000
Copy link
Contributor

Not sure about make all and make install (which requires a particular sunfire account access), but I'm able to make the individual file. Updated the README to prevent confusion when seeing source_X and source_week_X.

@remo5000 remo5000 changed the title Source Week 1 is an internal reference for the Avengers Add Source Week 1 as an internal reference for the Avengers Aug 22, 2018
@remo5000 remo5000 merged commit bdedd50 into master Aug 22, 2018
@martin-henz
Copy link
Member Author

Sorry, I missed these comments. Good points. Yes, let's include the Week 1 document in
make all
but exclude it from
make install

Can you please change the Makefile accordingly?

Thanks,

-martin

@ning-y ning-y deleted the source-week-1 branch August 23, 2018 00:46
martin-henz added a commit that referenced this pull request Apr 5, 2020
* Add support for non-deterministic Source 3

Non deterministic Source 3 is a version of Source 3 with a built-in search mechanism.
Programmers can specify sets of values, and requirements that the values must satisfy.
The evaluator then automatically identifies the values that meet the requirements.

* Fix function printing bug in non-det REPL (#30)

* fix repl printing bug

* Fix block scoping, and add tests

* Test more cases where errors are thrown

Test:
- Reassigning to constants
- Wrong number of arguments to function application
- Accessing an un-declared variable
- Having a non-boolean value as the predicate of a condtional expr
- Applying unary operator on wrong argument type
- Applying binary operator on wrong argument type

* Move require to the prelude (#33)

* Move require to prelude

* add tests and remove unused code (#34)

Adds tests for uncovered lines.

* add back return value unwrapping

* Add variant property in Context

* Fix code style issue

* Make variant property non-optional

* make requested changes

Co-authored-by: Arsalan Cheema <[email protected]>
Co-authored-by: martin-henz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants