Skip to content

REPL: add variant option #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 4, 2020
Merged

REPL: add variant option #549

merged 24 commits into from
May 4, 2020

Conversation

arsalan0c
Copy link
Member

@arsalan0c arsalan0c commented Apr 16, 2020 •
edited
Loading

This PR adds an option to the REPL for specifying a variant.

It also defines the supported chapter and variant combinations and uses it to check if the chapter and variant values passed to the REPL are valid.

Resolves #582

@arsalan0c arsalan0c requested a review from martin-henz April 16, 2020 15:09
@coveralls
Copy link

coveralls commented Apr 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 3274

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 83.517%
Totals Coverage Status
Change from base Build 3273: 0.002%
Covered Lines: 6467
Relevant Lines: 7458
💛 - Coveralls

@arsalan0c arsalan0c mentioned this pull request Apr 16, 2020
Merged
@martin-henz martin-henz changed the title REPL: add variant option [WIP] REPL: add variant option Apr 17, 2020
@martin-henz martin-henz requested review from openorclose and removed request for martin-henz April 17, 2020 05:41
@martin-henz
Copy link
Member

Someone needs to clean this up. We should have:

  -c, --chapter=CHAPTER set the Source chapter number (i.e., 1-4) (default: 1)
  -v, --variant=..., one of default, lazy, non-det, interpreter, stepper
  -h, --help            display this help
  -e, --eval            don't show REPL, only display output of evaluation```
So lazy, interpreter and subst can all be wrapped in variant. We shouldn't entertain all the possible combinations. It's already complicated enough.

@martin-henz martin-henz mentioned this pull request Apr 17, 2020
Closed
@arsalan0c arsalan0c mentioned this pull request Apr 28, 2020
Closed
arsalan0c and others added 17 commits April 28, 2020 13:14
@arsalan0c
Fix bug: yield new array (#40)
876cf2f 
* fix bug: yield new array for array expression
@arsalan0c
Add user friendly REPL message (#43)
75c0fdd 
* add user friendly REPL message
@arsalan0c
Add randomized amb operator (#15)
72836aa 
Adds the ambR operator which functions similarly to amb
but makes choices randomly instead of sequentially.

Also adds landing page and library documentation for
the operator, and adds this operator into the specs.
@arsalan0c
Merge branch 'master' of https://github.com/source-academy/js-slang
f78fd56
@arsalan0c
Merge branch 'master' into repl_variant
c56a4e8
@arsalan0c @anubh-v
Add while loops (#39)
b9f8a78 
This PR adds support for while loops, including break,
continue and return statements in the loop body.

It also tweaks the scheduler so that stackoverflow errors
are captured and displayed to the user.

Co-authored-by: anubh-v <[email protected]>
@anubh-v
Merge branch 'master' into master
29586b9
@anubh-v
Clear the stack trace of any error created in REPL (#46)
da5901e
@arsalan0c @anubh-v
Add for loops (#41)
4c851c7 
This PR adds support for for loops, including break,
continue and return statements in the loop body.
Co-authored-by: Anubhav <[email protected]>
@arsalan0c @anubh-v
Add documentation for loops (#44)
287adff 

Co-authored-by: anubh-v <[email protected]>
@anubh-v
Improve comments in non-det interpreter (#47)
4e64333 
* Remove unhelpful comment

* Fix spelling in comment
@anubh-v
Merge branch 'master' into master
f1f1995
@martin-henz
Merge branch 'master' into master
a5a0c02
@arsalan0c
Merge branch 'master' of https://github.com/source-academy/js-slang
e9910fc
@arsalan0c
Merge branch 'master' into repl_variant
e58ed02
@arsalan0c
allow only supported chapter and variant combinations
076d8ba
@arsalan0c
Merge branch 'repl_variant' of https://github.com/arsalanc-v2/js-slang …
ac9962e 
…into repl_variant
@arsalan0c arsalan0c mentioned this pull request May 2, 2020
Merged
@arsalan0c arsalan0c changed the title [WIP] REPL: add variant option REPL: add variant option May 2, 2020
@arsalan0c arsalan0c changed the title REPL: add variant option [WIP] REPL: add variant option May 2, 2020
@arsalan0c arsalan0c changed the title [WIP] REPL: add variant option REPL: add variant option May 2, 2020
@martin-henz martin-henz merged commit 01f7c81 into source-academy:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@openorclose openorclose Awaiting requested review from openorclose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chapter and variant combinations are undefined
4 participants
@arsalan0c @coveralls @martin-henz @anubh-v