Disable function expressions #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, something like this is permitted(!!):
It's undocumented and messes up the environment model (no binding for
a
is created in the calling frame).Happens because estree is converting it to a function expression (which we include as an undocumented feature) if it sees a function declaration where it expects an expression.
To make js-slang align with the spec, this PR disables both named and unnamed function definition expressions. Only arrow functions are allowed as an expression now.