Skip to content

[JetBrains, Java Renderer] Backslash ambiguous in oblique fonts #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamquaile opened this issue Sep 1, 2015 · 9 comments
Closed

Comments

@adamquaile
Copy link

When a backslash appears in the italic/oblique font, it is understandably vertical. If it were still leaning back a little, it would help distinguish it from the pipe.

Here is the backslash in oblique and regular.
backslash

@chrissimpkins
Copy link
Member

Here is how it is designed to appear in all oblique:
backslash-char

Is this a JetBrains editor? There are italics rendering issues with their Java renderer (Issue #26). Based upon what I know to date, this seems to be limited to OS X versions only.

The Java renderer is taking the regular set and adding its own slant (too much) when these syntax highlighters use italics. It doesn't occur with all fonts but it does affect others and I am trying to get feedback from JetBrains re: why this is an issue for Hack.

@adamquaile
Copy link
Author

Yes, it is a JetBrains editor, on Mac too, so it sounds like this is a known bug then. Thanks.

@chrissimpkins
Copy link
Member

If you intend to continue to use the font, keep an eye on that thread and I will add any additional information that I receive. I am not terribly hopeful that this is going to land on their to-do list soon because there are reports of this problem that date back over a year in their issue tracker.

@adamquaile
Copy link
Author

I've only been using it from today, but this is the only issue I've noticed and for the kind of environment I'm in it's a pretty minor one.

It doesn't appear often and I'll just turn italics off where it does. Nice work, by the way - I'm liking it so far.

@chrissimpkins
Copy link
Member

Really glad to hear that Adam.  Let me know if you come across any other issues.


Chris

On Tue, Sep 1, 2015 at 2:59 PM, Adam Quaile [email protected]
wrote:

I've only been using it from today, but this is the only issue I've noticed and for the kind of environment I'm in it's a pretty minor one.

It doesn't appear often and I'll just turn italics off where it does. Nice work, by the way - I'm liking it so far.

Reply to this email directly or view it on GitHub:
#67 (comment)

@chrissimpkins chrissimpkins changed the title Backslash ambiguous in oblique fonts [JetBrains editors] Backslash ambiguous in oblique fonts Sep 2, 2015
@chrissimpkins chrissimpkins changed the title [JetBrains editors] Backslash ambiguous in oblique fonts [JetBrains, Java Renderer] Backslash ambiguous in oblique fonts Sep 2, 2015
@chrissimpkins
Copy link
Member

Will you please give these new builds a try (v2.012)? I've updated the name tables and adjusted the font names based upon what is currently recommended for cross-platform support. Let's see if this addresses this issue.

Download Links
Regular
Bold
Italic
BoldItalic

@adamquaile
Copy link
Author

I've just tried this on the same platform (not the same computer) and the backslash looks perfect.

@chrissimpkins
Copy link
Member

Great! Progress... (and potentially a few closed issue reports). Will merge this into master this weekend. Thank you very much for the report. It happened to be associated with a number of other reported issues. I will close this once it is merged.

@chrissimpkins
Copy link
Member

Thank you very much for reporting this issue Adam. The fix is now included in the v2.013 release which was merged into the master branch. I will close this issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants