Skip to content

test(provider): add test cases for Cognito OAuth#102

Merged
akshatdubeysf merged 1 commit intomasterfrom
cognito-tests
Nov 21, 2022
Merged

test(provider): add test cases for Cognito OAuth#102
akshatdubeysf merged 1 commit intomasterfrom
cognito-tests

Conversation

@AnkurBansalSF
Copy link
Copy Markdown
Contributor

@AnkurBansalSF AnkurBansalSF commented Oct 26, 2022

Description

added test cases for Cognito OAuth.

Fixes #97

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

added test cases for Cognito OAuth

gh-97
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yeshamavani
Copy link
Copy Markdown
Contributor

Add screenshot of test coverage

@AnkurBansalSF
Copy link
Copy Markdown
Contributor Author

Screenshot from 2022-11-16 17-13-40
Screenshot from 2022-11-16 17-14-16
Screenshot from 2022-11-16 17-14-21

/**
* A provider for default implementation of VerifyFunction.CognitoAuthFn
*
* It will just throw an error saying Not Implemented
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it will do this 🙂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mock-verify-provider naa. It will just return the user (like other verify-providers).
This comment is from the actual verify provider, forgot to remove it. 😅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 🙁

@akshatdubeysf akshatdubeysf merged commit d3c864f into master Nov 21, 2022
@akshatdubeysf akshatdubeysf deleted the cognito-tests branch November 21, 2022 13:09
@yeshamavani
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amazon Cognito OAuth Login

3 participants