Skip to content

feat(middleware): add client and user authentication middleware#90

Merged
akshatdubeysf merged 1 commit intomasterfrom
GH-32
Sep 23, 2022
Merged

feat(middleware): add client and user authentication middleware#90
akshatdubeysf merged 1 commit intomasterfrom
GH-32

Conversation

@barleendhaliwal
Copy link
Copy Markdown
Contributor

Description

Provide middleware based sequence support as action based sequence will be deprecated soon.

  • Added client and user authentication middleware
  • Added Config key to which binding can be done to enable these middlewares
  • Rectified integration test - "should return 302 when client id is passed and passReqToCallback is set true" for apple, intagram, keycloak and google strategies
  • Added integration test cases for using middleware based sequence
  • Updated readme
  • deleted dist folder so that it no longer shows in changes

Fixes # (GH-32)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@barleendhaliwal barleendhaliwal force-pushed the GH-32 branch 2 times, most recently from 376a140 to 92e680c Compare July 18, 2022 06:25
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akshatdubeysf akshatdubeysf merged commit 0e470f8 into master Sep 23, 2022
@akshatdubeysf akshatdubeysf deleted the GH-32 branch September 23, 2022 07:59
@yeshamavani
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants