perf(chore): sonar fixes (#847)

gh-845

Author: yeshamavani

packages/core/src/components/bearer-verifier/component.ts

@@ -1,6 +1,7 @@
 import {Binding, Component, inject, ProviderMap} from '@loopback/core';
 import {Class, Model, Repository} from '@loopback/repository';
 import {Strategies} from 'loopback4-authentication';
+import {ILogger, LOGGER} from '../logger-extension';
 
 import {
   BearerVerifierBindings,
@@ -16,6 +17,7 @@ export class BearerVerifierComponent implements Component {
   constructor(
     @inject(BearerVerifierBindings.Config)
     private readonly config: BearerVerifierConfig,
+    @inject(LOGGER.LOGGER_INJECT) public logger: ILogger,
   ) {
     this.providers = {};
     this.repositories = [RevokedTokenRepository];
@@ -29,7 +31,7 @@ export class BearerVerifierComponent implements Component {
       this.providers[Strategies.Passport.BEARER_TOKEN_VERIFIER.key] =
         FacadesBearerTokenVerifyProvider;
     } else {
-      console.error('Invalid BearerVerifierType specified !');
+      this.logger.error('Invalid BearerVerifierType specified !');
     }
   }
   providers?: ProviderMap;

packages/core/src/components/logger-extension/component.ts

@@ -3,7 +3,8 @@ import {LOGGER} from './keys';
 import {LoggerProvider} from './providers/logger.provider';
 
 export class LoggerExtensionComponent implements Component {
-  constructor() {}
-
-  providers?: ProviderMap = {[LOGGER.BINDINGS.LOG_ACTION.key]: LoggerProvider};
+  providers: ProviderMap = {};
+  constructor() {
+    this.providers = {[LOGGER.BINDINGS.LOG_ACTION.key]: LoggerProvider};
+  }
 }

packages/core/src/components/logger-extension/winston/logger-base.ts

@@ -4,8 +4,6 @@ import {LogMessage} from '../types';
 import {LOGGER} from '../keys';
 
 export class WinstonLoggerBase implements ILogger {
-  constructor() {}
-
   logger: WinstonLogger;
 
   log(info: LogMessage): void {

packages/core/src/components/swagger-authentication/middlewares/authenticate-swagger.middleware.ts

@@ -14,6 +14,7 @@ import {
 import {MiddlewareContext, Middleware} from '@loopback/express';
 import {SwaggerAuthenticationBindings} from '../keys';
 import {HttpAuthenticationVerifier} from '../types';
+import {STATUS_CODE} from '../../../enums';
 
 @globalInterceptor('auth', {tags: {name: 'AuthenticateSwaggerMiddleware'}})
 export class AuthenticateSwaggerMiddlewareInterceptor
@@ -43,7 +44,7 @@ export class AuthenticateSwaggerMiddlewareInterceptor
       const verified = this.verifier(username, password);
       if (!verified) {
         response
-          .status(401)
+          .status(STATUS_CODE.UNAUTHORISED)
           .setHeader('WWW-Authenticate', 'Basic realm="Node"');
         response.end('Unauthorized');
         return null;

packages/core/src/models/success-response.dto.ts

@@ -9,7 +9,7 @@ export class SuccessResponse extends Model {
 
   // Indexer property to allow additional data
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [prop: string]: any;
+  [prop: string]: any; //NOSONAR
 
   constructor(data?: Partial<SuccessResponse>) {
     super(data);

packages/core/src/models/upsert-response.dto.ts

@@ -19,7 +19,7 @@ export class UpsertResponse extends Model {
 
   // Indexer property to allow additional data
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [prop: string]: any;
+  [prop: string]: any; //NOSONAR
 
   constructor(data?: Partial<UpsertResponse>) {
     super(data);

packages/search/projects/search-lib/karma.conf.js

@@ -1,6 +1,7 @@
 // Karma configuration file, see link for more information
 // https://karma-runner.github.io/1.0/config/configuration-file.html
 
+// sonarignore:start
 module.exports = function (config) {
   config.set({
     basePath: '',
@@ -39,3 +40,4 @@ module.exports = function (config) {
     restartOnFileChange: true,
   });
 };
+// sonarignore:end

sandbox/audit-ms-example/src/models/to-do.model.ts

@@ -32,8 +32,4 @@ export class ToDo extends Entity {
   }
 }
 
-export interface ToDoRelations {
-  // describe navigational properties here
-}
-
-export type ToDoWithRelations = ToDo & ToDoRelations;
+export type ToDoWithRelations = ToDo;

sandbox/auth-multitenant-example/src/__tests__/acceptance/todo.controller.acceptance.ts

@@ -12,8 +12,8 @@ describe('PingController', () => {
     sarah: null,
   };
 
-  const client_id = 'temp_client';
-  const client_secret = 'temp_secret';
+  const clientId = 'temp_client';
+  const clientSecret = 'temp_secret';
   const todo = {
     title: 'Testing',
     description: 'Test description',
@@ -26,14 +26,14 @@ describe('PingController', () => {
 
   before('get auth tokens', async () => {
     const johnAuthRes = await client.post('/auth/login-token').send({
-      client_id,
-      client_secret,
+      client_id: clientId,
+      client_secret: clientSecret,
       username: 'john.doe@example.com',
       password: 'test123!@#',
     });
     const sarahAuthRes = await client.post('/auth/login-token').send({
-      client_id,
-      client_secret,
+      client_id: clientId,
+      client_secret: clientSecret,
       username: 'sarah.rafferty@example.com',
       password: 'test123!@#',
     });

sandbox/auth-multitenant-example/src/index.ts

@@ -5,6 +5,8 @@ import {
 
 export * from './application';
 
+const port = 3000;
+
 export async function main(
   options: ApplicationConfig = {},
 ): Promise<AuthMultitenantExampleApplication> {
@@ -23,7 +25,7 @@ if (require.main === module) {
   // Run the application
   const config = {
     rest: {
-      port: +(process.env.PORT ?? 3000),
+      port: +(process.env.PORT ?? port),
       host: process.env.HOST,
       // The `gracePeriodForClose` provides a graceful close for http/https
       // servers with keep-alive clients. The default value is `Infinity`