perf(chore): sonar fixes#847
Merged
Merged
Conversation
samarpan-b
requested changes
Jun 23, 2022
| import {inject} from '@loopback/core'; | ||
| import {Request, RestBindings, get, ResponseObject} from '@loopback/rest'; | ||
| import {CONTENT_TYPE, STATUS_CODE} from '@sourceloop/core'; | ||
| import {CONTENT_TYPE, STATUS_CODE} from '@sourceloop/core'; //NOSONAR |
| }; | ||
|
|
||
| it('return true if Feature Toggle is not set', async () => { | ||
| it(ftNotSet, async () => { |
Contributor
There was a problem hiding this comment.
not correct. why are we having 2 test cases with same description ? That cant be possible.
Contributor
Author
There was a problem hiding this comment.
will remove this
also this files I am changing and writing new test cases as we have moved the decorator to package. can we ignore this for now ?
Contributor
There was a problem hiding this comment.
comment out or remove the incorrect test cases then
| import {ContractRepository, OcrResultRepository} from '../repositories'; | ||
| import {CreateClauseData} from '../types'; | ||
|
|
||
| const clauseId = '/clauses/{id}'; |
|
Kudos, SonarCloud Quality Gate passed!
|
samarpan-b
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-845
Description
Fixing the overall sonar issues
Fixes #845
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: