This repository was archived by the owner on Nov 25, 2021. It is now read-only.
feat: resolveContext can be an observable #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijsnow
commented
Jul 30, 2018
| return of({ position: { ...context, ...position }, ...rest }) | ||
| } | ||
|
|
||
| return of({ position: undefined, ...rest }) |
Contributor
Author
There was a problem hiding this comment.
It seems like this type is never considered. If you hover over position on line 379 in this file, you'll see that the type doesn't include | undefined any more.
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 63.71% 63.68% -0.04%
==========================================
Files 15 15
Lines 565 570 +5
Branches 146 147 +1
==========================================
+ Hits 360 363 +3
- Misses 205 207 +2
Continue to review full report at Codecov.
|
Contributor
|
I am more inclined to make a breaking change and require |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE
This is a WIP PR to support async
ContextResolvers. This should work but is not tested. I stopped working on it because the types seem to be messed up and I have no idea why. I'll Comment on the lines where the issues are.