Go mod tidy sourcegraph

[eseliger]

This is a campaign run to fulfill the delivery plan https://github.com/sourcegraph/customer/issues/13.
Over the coming days, I will update more repositories using go mod tidy.

[codecov]

Codecov Report

Merging #40 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   26.91%   26.91%           
=======================================
  Files           5        5           
  Lines        1133     1133           
=======================================
  Hits          305      305           
  Misses        784      784           
  Partials       44       44           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3637c60...7a60fdd. Read the comment docs.

[keegancsmith]

This seems to just make it so we can't build with an earlier go? So I'd rather we didn't merge this.

[eseliger]

I have unfortunately no idea what the directive is used for :D but I'm happy to close it, as that will also be a good data point for me testing out the roll-out with all sorts of scenarios!
I might end up moving this campaign to k8s.sgdev.org so I might have to reopen this PR, will close again then though

[dmitshur]

Setting the Go language version to 1.14 means that language features that are new to 1.14 may be used, and things that were deprecated/removed may not be.

Since there aren't code changes here, the packages in this module would still build successfully with older versions of Go.

It'd be completely reasonable to specify an older version of the Go language if your intention is not to use any newer Go language features.

See issue golang/go#30791 about documenting the go directive better so it's easier for module authors to choose a good value for it.

[keegancsmith]

Thanks @dmitshur. So this won't affect any modules which depend on go-diff? If so LGTM

[keegancsmith]

Next time I will read the link before asking a question. Looks like this does what I expect.

[eseliger]

Thanks for jumping in @dmitshur! I am going to close this PR and will recreate it in the coming hours or days, as the new campaign rollout test will originate from our dogfood instance.

[dmitshur]

The go directive affects only the Go packages in the module it's in.

Based on what you said, setting it to a lower value like go 1.13 may be a better fit. The module is tidy as long as the go directive is present, it doesn't have to be exactly 1.14. That was just the default value.