-
Notifications
You must be signed in to change notification settings - Fork 49
Add handling added/deleted files in diff #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling added/deleted files in diff #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 28.31% 29.48% +1.17%
==========================================
Files 5 5
Lines 1155 1177 +22
==========================================
+ Hits 327 347 +20
- Misses 783 784 +1
- Partials 45 46 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added some comments. Final decision on how to implement this is with the repo owners of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will want @eseliger to take a look as well.
BTW thank you so much for the great pull request! |
Related issue: #49
closes #49
There are some changes from planned implementation:
nil
OrigName
field.[2].OrigName: "source_b/file_3.txt
and[2].NewName: ""
will be relevant.Because in case diff file only contains messages about added/deleted files, it is impossible to determine which of the sources is the original one.
Then for this file example, the output below for ReadAllFiles() would be expected.
my_diff.txt