This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Implement the 'textDocument/rename' command #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
reviewed
Nov 5, 2018
|
Thanks! I will try to add some tests in the next days. I see that is possible to spin up a tests langserver. |
|
@keegancsmith I added some tests for rename command. Please could you have a look? Thanks |
|
Plus 1 for this. #220 |
|
@keegancsmith Any chance to get this merged soon? Thanks |
Shit sorry, did not mean to ignore this. I'll take a look now. |
keegancsmith
approved these changes
Nov 26, 2018
| } | ||
|
|
||
| result := lsp.WorkspaceEdit{} | ||
| if result.Changes == nil { |
There was a problem hiding this comment.
nit: result.Changes will always be nil here. Rather just initialize it
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.