This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Strip .git suffix from dependencies #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying and then falling back seems better than stripping the |
|
Switched to trying then falling back. |
beyang
approved these changes
Apr 12, 2019
keegancsmith
approved these changes
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users have import paths that look like
example.com/user/repo.gitand the repository name on Sourcegraph isexample.com/user/repo(without.git).Prior to this change, go-langserver would attempt to fetch
example.com/user/repo.gitand get a 404.After this change, go-langserver will fetch
example.com/user/repoinstead. This will break when the repository name on Sourcegraph has a.gitsuffix. @beyang Does that seem acceptable? Alternatively, go-langserver could try the original (with.git) and then fallback to dropping the suffix.This worked in Sourcegraph 2.x probably because the repository contents were obtained through lsp-proxy and gitserver, rather than the raw API.