This repository was archived by the owner on Jul 28, 2022. It is now read-only.
fix travis release branch conditonal #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ggilmore could you give a PR description? What problem does this fix? |
Collaborator
Author
|
When you push a tag |
Contributor
|
And why do we need to build the Docker images on tags? Since every tag is for a commit, that same commit will have already been build, so wouldn't we build it twice? |
Contributor
|
ping @ggilmore |
Collaborator
Author
|
Sorry I missed this. You're right that it's redundant, but I don't see it
as really that big a deal for now (especially since we release so
infrequently)
…On Wed, Jun 13, 2018 at 2:10 PM Felix Becker ***@***.***> wrote:
ping @ggilmore <https://github.com/ggilmore>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AImqOwzpNJLSKoxKIZxJvX4uXloP7_GLks5t8X-5gaJpZM4UZzJK>
.
|
Contributor
|
So all we need to do is revert this PR? |
Collaborator
Author
|
No, because then pushing tags to make a new release won't work.
…On Wed, Jun 13, 2018 at 2:47 PM Felix Becker ***@***.***> wrote:
So all we need to do is revert this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AImqO4o2kQw-mHAlKM1OtuRGFkpplbVtks5t8YiBgaJpZM4UZzJK>
.
|
Collaborator
Author
|
This PR is still valuable, it just that it also builds redundant images as
you pointed out
On Wed, Jun 13, 2018 at 2:48 PM Geoffrey Gilmore <[email protected]>
wrote:
… No, because then pushing tags to make a new release won't work.
On Wed, Jun 13, 2018 at 2:47 PM Felix Becker ***@***.***>
wrote:
> So all we need to do is revert this PR?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#85 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AImqO4o2kQw-mHAlKM1OtuRGFkpplbVtks5t8YiBgaJpZM4UZzJK>
> .
>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.