Skip to content

style(clang-tidy): fix bugprone-return-const-ref-from-parameter errors #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 20, 2025
Merged

style(clang-tidy): fix bugprone-return-const-ref-from-parameter errors #1732

merged 9 commits into from
Jun 20, 2025

Conversation

bavulapati
Copy link
Contributor

fixes #1657

@bavulapati
style(clang-tidy): fix bugprone-return-const-ref-from-parameter errors
6d8d981 
fixes sourcemeta#1657

Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
fix format issue
2370cb5 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
revert config
c20b4d7 
Signed-off-by: Balakrishna Avulapati <[email protected]>
bavulapati
bavulapati commented Jun 20, 2025
View reviewed changes
@bavulapati
use overloaded function to fix
8ae6423 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
fix format
a745cc0 
Signed-off-by: Balakrishna Avulapati <[email protected]>
jviotti
jviotti reviewed Jun 20, 2025
View reviewed changes
jviotti
jviotti reviewed Jun 20, 2025
View reviewed changes
@bavulapati
Add comment and place function declarations closer to the overloaded …
8b4dddd 
…functions

Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
Remove const from the parameters
7ce0929 
Signed-off-by: Balakrishna Avulapati <[email protected]>
@bavulapati
fix format
ca37d40 
Signed-off-by: Balakrishna Avulapati <[email protected]>
jviotti
jviotti reviewed Jun 20, 2025
View reviewed changes
jviotti
jviotti reviewed Jun 20, 2025
View reviewed changes
@jviotti
Apply suggestions from code review
839dcd8 
Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti
Copy link
Member

jviotti commented Jun 20, 2025

I just removed the overloaded function comments (as that's implicit), but otherwise looks good. Thanks!

@jviotti jviotti merged commit d9fa8a3 into sourcemeta:main Jun 20, 2025
14 checks passed
@bavulapati bavulapati deleted the fix-bugprone-return-const-ref-from-parameter branch June 20, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClangTidy warnings for bugprone-return-const-ref-from-parameter
2 participants
@bavulapati @jviotti