Support element type infer of Array and Hash#220
Merged
soutaro merged 3 commits intosoutaro:mainfrom Feb 12, 2026
Merged
Conversation
## Motivation I want rbs-inline to infer types for Array and Hash constants automatically. This should work when elements are explicit literals, even without manual annotations. Currently, rbs-inline handles simple literals. It is natural to extend this to collections of literals. Array and Hash constants are common in many applications. For example, defining model statuses: ```ruby EXECUTABLE_STATUSES = %w(scheduled pending) ``` Domain logic often uses these constants for business rules. Since the types are obvious, rbs-inline should generate RBS automatically. This reduces the need for redundant inline annotations. ## Scope This patch only addresses simple cases that are realistically expected to be used in application code. - It only supports explicit literals. - It does not support Union Types for mixed-type collections (e.g., [1, "s"]). I believe mixed-type constants are rare in practice. Supporting single-type collections covers most real-world use cases while avoiding unnecessary complexity.
dak2
force-pushed
the
support-element-type-infer
branch
from
44a9b9e to
361a3db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I want rbs-inline to infer element types for Array and Hash constants automatically.
This should work when elements are explicit literals, even without manual annotations.
Currently, rbs-inline handles simple literals.
It is natural to extend this to collections of literals.
Array and Hash constants are common in many applications. For example, defining model statuses:
Domain logic often uses these constants for business rules.
Since the types are obvious, rbs-inline should generate RBS automatically.
This reduces the need for redundant inline annotations.
Scope
This patch only addresses simple cases that are realistically expected to be used in application code.
I believe mixed-type constants are rare in practice.
Supporting single-type collections covers most real-world use cases while avoiding unnecessary complexity.