Fix sleep when no change in spectrum is requested#126
Merged
Conversation
Collaborator
Author
|
Untested on hardware, but imo this should be fine without testing. |
Collaborator
Author
|
A slightly confusing part is that @raphaelpclt reported 0.19sec for a no-move |
Collaborator
|
New test with IPython Almost a factor of 2, but still a lot |
Collaborator
|
Well I ran both methods from the same Jupyter notebook. They seem to give the same result. The result my depend on whether we are on a full moon day or not. 
|
Collaborator
Author
|
Tested on hardware. Fixed one typo. Setting the spectrum repeatedly now takes ~500us. 
|
raphaelpclt
approved these changes
Oct 19, 2023
raphaelpclt
left a comment
raphaelpclt
left a comment
Collaborator
There was a problem hiding this comment.
Tested with @ehpor, all good
ehpor
force-pushed
the
bugfix/early_return_on_no_move
branch
from
b80a7d2 to
7421ec2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the VARIA return early when there is no change in filters. Fixes #125
Also raises an error when negative bandwidths are requested. Fixes https://github.com/spacetelescope/hicat-package2/issues/291
This PR supersedes PR #104.