HLA-1133/1241/1288 Implementation of ACS Serial CTE correction#609
Merged
Conversation
mdlpstsci
changed the title
This was done manually to view all the differences between the structure of the previous and "The Reunion" versions of HSTCAL.
Renamed dopcte-gen2.c to dpcte-gen3.c.
mdlpstsci
force-pushed
the
acs_serial_cte
branch
from
f0b705d to
0f612f8
Compare
more appropriate location in the code.
mdlpstsci
changed the title
mdlpstsci
changed the title
is NOT backwards compatible. WFC RAW files will need to have the PCTETAB keyword in the primary header updated with the name of the update calibration file which supports both parallel and serial CTE corrections.
Contributor
Author
|
Test run done with new RAW and updated Truth files: |
mdlpstsci
changed the title
Contributor
Author
|
The software for this PR has been approved by the ACS Team (Jenna Ryon) (Git Issue #577). In order to merge a code review needs to be done. |
raswaters
approved these changes
Nov 21, 2024
| c_tbtclo(tbl_ptr); | ||
| return status; | ||
| } | ||
| sprintf(MsgText,"CTEDATE0: %g",pars->cte_date0); |
There was a problem hiding this comment.
Indentation incorrect? 390/1, 401/2, 412/3, 423/4, 434/6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code represents the Generation 3 version of the CTE correction for ACS WFC. This code applies not only the parallel CTE correction for full-frame images, but it also applies a serial CTE correction for post-SM4 data.
Note: In order to use this new version of CALACS (v10.4.0), the PCTETAB keyword in the primary header MUST be populated with the name of the Generation 3 PCTETAB calibration reference file.