Skip to content

Avoid making object arrays for mask in cubeviz to speed up loading large cubes #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kecnry merged 3 commits into from
Sep 17, 2025
Merged

Avoid making object arrays for mask in cubeviz to speed up loading large cubes #3787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
896333a
Avoid making object arrays for mask
astrofrog Sep 17, 2025
5896970
Added changelog entry
astrofrog Sep 17, 2025
5025b02
Move changelog entry
astrofrog Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ Bug Fixes
Cubeviz
^^^^^^^

- Speed up loading of large cubes into cubeviz. [#3787]

Imviz
^^^^^

Expand Down
5 changes: 4 additions & 1 deletion jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,10 @@ def _extract_from_aperture(self, cube, uncert_cube, mask_cube, aperture,
wcs = cube.coords

# Filter out NaNs (False = good)
mask = np.logical_or(mask, np.isnan(flux))
if mask is None:
mask = np.isnan(flux)
else:
mask = np.logical_or(mask, np.isnan(flux))

# Also apply the cube's original mask array
if mask_cube:
Expand Down
Loading