Skip to content

lcviz deconfigged compatibility#4135

Open
kecnry wants to merge 13 commits into
spacetelescope:mainfrom
kecnry:lcviz-compat
Open

lcviz deconfigged compatibility#4135
kecnry wants to merge 13 commits into
spacetelescope:mainfrom
kecnry:lcviz-compat

Conversation

@kecnry
Copy link
Copy Markdown
Member

@kecnry kecnry commented Apr 13, 2026

Description

This pull request adds support for lcviz to inject itself into deconfigged jdaviz in the upcoming 5.0 release, including:

  • allows downstream to inject functionality into: about, markers (including support for plugin tables to skip empty columns since lcviz will inject new columns but not need to use some of the jdaviz defaults), plot options, subset tools, coords info (mouseover),
  • fixes bugs when adding lc data for: slice, sonify, ramp extraction

Accompanying lcviz PR that can be used for testing: spacetelescope/lcviz#215

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.6 milestone Apr 13, 2026
@github-actions github-actions Bot added cubeviz embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations rampviz labels Apr 13, 2026
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Apr 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 74.56140% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.62%. Comparing base (17224da) to head (0325e12).

Files with missing lines Patch % Lines
...z/configs/imviz/plugins/coords_info/coords_info.py 47.36% 10 Missing ⚠️
...nfigs/default/plugins/plot_options/plot_options.py 55.55% 8 Missing ⚠️
jdaviz/__init__.py 42.85% 4 Missing ⚠️
jdaviz/configs/default/plugins/about/about.py 42.85% 4 Missing ⚠️
jdaviz/core/template_mixin.py 88.88% 2 Missing ⚠️
jdaviz/core/loaders/importers/image/image.py 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (74.56%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4135      +/-   ##
==========================================
- Coverage   84.66%   84.62%   -0.04%     
==========================================
  Files         205      205              
  Lines       30418    30525     +107     
==========================================
+ Hits        25753    25832      +79     
- Misses       4665     4693      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kecnry kecnry marked this pull request as ready for review April 14, 2026 18:26
@rosteen rosteen modified the milestones: 4.6, 5.1 Apr 15, 2026
@kecnry kecnry modified the milestones: 5.1, 5.0.1 Apr 17, 2026
@rosteen
Copy link
Copy Markdown
Collaborator

rosteen commented Apr 29, 2026

Overall the hooks into Jdaviz seem to work, I was able to load a light curve, use most of the plugins, and create the LCViz viewer types. I ran into a few problems that may be related to the integration with 5.0:

  1. In the time selector plugin, most of the buttons don't do anything, and pressing Jump to First/Last give an error traceback. I suspect this is all due to valid_values in slice.py being empty.
  2. Switching flux column (e.g., between non-flattened and flattened flux) doesn't automatically home zoom any viewers, you have to press the button on each to see the data after switching. I think I remember not needing to do this manually previously.
  3. Should the unit plugin have different fields for the LCViz context (e.g., add a time unit?). Currently only spectral unit is populated with anything in the menu, despite nothing loaded having spectral units:
Screenshot 2026-04-29 at 2 58 51 PM

@cshanahan1 cshanahan1 modified the milestones: 5.0.1, 5.0.2 May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cubeviz embed Regarding issues with front-end embedding imviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations rampviz

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants