Oss version mid#412
Merged
Witchblade101 merged 6 commits intoMar 24, 2026
Merged
Conversation
Collaborator
|
The code changes look good to me. The reference data (pre_delivery_data) should be attached here rather than added to source control, if possible. |
york-stsci
approved these changes
Mar 24, 2026
Collaborator
york-stsci
left a comment
york-stsci
left a comment
There was a problem hiding this comment.
Pending the moving of pre_delivery_data to the PR rather than to version control, these changes look good.
Collaborator
|
This comment attaches the "pre_delivery_data" directory as a compressed archive of text files. These files show that the differences in output files produced by this branch and the main branch consist only of the added OSS_Version keyword. |
Collaborator
Author
|
Deleted pre_delivery_data and updated PR. After this is approved and merged, I'll need to open a new PR to merge these changes unto the siaf-updates branch used to make instrument changes. |
mfixstsci
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new OSS_Version column with default values (issue #411 ). Also includes pre-delivery data that includes the manually edited apertures for NIRCam and FGS.