Adding awareness of OSS version values#419
Conversation
BradleySappington
left a comment
There was a problem hiding this comment.
Please utilize pysiaf/utils/tools.py and add a single method to fill aperture.OSS_Version
that can be referenced from all of these places.
|
Function added. I can't abstract more than this because the different output formats handle things very differently. |
|
Discussion moved to slack/in-person for clarity |
|
Code change made. I have also confirmed with @Witchblade101 that when he runs the code he also gets identical results to his hand-made correct files. |
BradleySappington
left a comment
There was a problem hiding this comment.
A few more small adjustments then I think you're good to go!
|
My only further request is that we shouldn't generate csv files by default. Once were done with testing revert that back to just XML and Excel. |
… resulting table is identical
|
@Witchblade101 I've added argparse to the generate scripts, and set the default to be emulate_delivery=True, and file_formats="xml,xlsx", so if you run the script with no arguments you'll get exactly what you used to get, but you can also now set formats and emulate by using the command line, and use "--help" to see the available arguments. |
This is the start of work on handling different OSS version values for single apertures, and applying those values appropriately based on input values.
Currently this version adds two files to the source_data directory.
This code includes adding a read function to read in the table, adding filtering functions to select the appropriate table row (in the generate_[instrument].py files), and adding logic to the write functions to loop through adding rows if there are multiple OSS versions for a single aperture at the write stage.
Currently it does not handle nircam cases with the same aperture but different DCCName values, if only because the current code, itself, does not handle those cases.