add romancal downstream testing to ci#559
Conversation
829a33c to
75aa1c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 96.61% 96.64% +0.02%
==========================================
Files 4 4
Lines 266 268 +2
==========================================
+ Hits 257 259 +2
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
947f450 to
d01d490
Compare
d01d490 to
04d454f
Compare
| roman_datamodels: git clone -n --depth=1 --filter=blob:none {[main]roman_datamodels_repo} | ||
| roman_datamodels: git --git-dir={env_tmp_dir}/roman_datamodels/.git checkout HEAD pyproject.toml | ||
| roman_datamodels: git --git-dir={env_tmp_dir}/roman_datamodels/.git checkout HEAD tests/* | ||
| romancal: git clone --depth=1 {[main]romancal_repo} |
There was a problem hiding this comment.
wow I didn't know you could define global vars!
|
Is this helpful without being able to easily tag an associated roman_datamodel? Typically we link the RCAL tests to the RDM PRs for that reason. |
I'd say this is still helpful. At the moment the 3 packages are quite entangled and as you mentioned almost every rad change requires a roman_datamodels PR (since the rad change breaks roman_datamodels). However most of these breakages are due to the maker utilities being out of sync with rad. Most romancal steps don't use maker utilities (and likely none should) and may use the new rad changes without issue. This will also help to catch failures that wouldn't be seen in the roman_datamodels tests. |
|
Okay - it doesn't hurt as long as it isn't a blocking test. |
Add romancal unit tests to the CI (similar to the roman_datamodels tests).
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change