Skip to content

add romancal downstream testing to ci#559

Merged
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:romancal_downstream
Apr 2, 2025
Merged

add romancal downstream testing to ci#559
braingram merged 1 commit into
spacetelescope:mainfrom
braingram:romancal_downstream

Conversation

@braingram
Copy link
Copy Markdown
Collaborator

@braingram braingram commented Apr 1, 2025

Add romancal unit tests to the CI (similar to the roman_datamodels tests).

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram force-pushed the romancal_downstream branch 2 times, most recently from 829a33c to 75aa1c3 Compare April 1, 2025 21:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (32af770) to head (04d454f).
Report is 149 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   96.61%   96.64%   +0.02%     
==========================================
  Files           4        4              
  Lines         266      268       +2     
==========================================
+ Hits          257      259       +2     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram force-pushed the romancal_downstream branch 2 times, most recently from 947f450 to d01d490 Compare April 1, 2025 21:22
@braingram braingram force-pushed the romancal_downstream branch from d01d490 to 04d454f Compare April 2, 2025 12:18
@braingram braingram marked this pull request as ready for review April 2, 2025 12:54
@braingram braingram requested review from a team and WilliamJamieson as code owners April 2, 2025 12:54
Comment thread tox.ini
roman_datamodels: git clone -n --depth=1 --filter=blob:none {[main]roman_datamodels_repo}
roman_datamodels: git --git-dir={env_tmp_dir}/roman_datamodels/.git checkout HEAD pyproject.toml
roman_datamodels: git --git-dir={env_tmp_dir}/roman_datamodels/.git checkout HEAD tests/*
romancal: git clone --depth=1 {[main]romancal_repo}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow I didn't know you could define global vars!

@PaulHuwe
Copy link
Copy Markdown
Collaborator

PaulHuwe commented Apr 2, 2025

Is this helpful without being able to easily tag an associated roman_datamodel? Typically we link the RCAL tests to the RDM PRs for that reason.

@braingram
Copy link
Copy Markdown
Collaborator Author

Is this helpful without being able to easily tag an associated roman_datamodel? Typically we link the RCAL tests to the RDM PRs for that reason.

I'd say this is still helpful.

At the moment the 3 packages are quite entangled and as you mentioned almost every rad change requires a roman_datamodels PR (since the rad change breaks roman_datamodels). However most of these breakages are due to the maker utilities being out of sync with rad. Most romancal steps don't use maker utilities (and likely none should) and may use the new rad changes without issue.

This will also help to catch failures that wouldn't be seen in the roman_datamodels tests.

@PaulHuwe
Copy link
Copy Markdown
Collaborator

PaulHuwe commented Apr 2, 2025

Okay - it doesn't hurt as long as it isn't a blocking test.

@braingram braingram merged commit e577f35 into spacetelescope:main Apr 2, 2025
15 checks passed
@braingram braingram deleted the romancal_downstream branch April 2, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants