Skip to content

Remove the FPS/TVAC schemas from latest#617

Merged
WilliamJamieson merged 5 commits into
spacetelescope:mainfrom
WilliamJamieson:static_fps_tvac
Jun 9, 2025
Merged

Remove the FPS/TVAC schemas from latest#617
WilliamJamieson merged 5 commits into
spacetelescope:mainfrom
WilliamJamieson:static_fps_tvac

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Collaborator

Closes #616

This PR removes the FPS and TVAC schemas from the latest schemas. In addition to this it adds them to a "new" manifest static (name can be changed), which denotes that the schemas tagged in it are no-longer going to be updated and will remain as they are. While not strictly necessary (everything will still function), this should become useful if we want to make changes to RDM which partially break handling of the associated static files, in that case we can build a distinct RDM extension which only handles those schemas where we can maintain a minimal functionality for file reads in RDM.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.77%. Comparing base (c57e0ca) to head (3c1c757).
⚠️ Report is 115 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_schemas.py 66.66% 2 Missing ⚠️
tests/conftest.py 98.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   97.46%   96.77%   -0.69%     
==========================================
  Files           8        8              
  Lines         592      621      +29     
==========================================
+ Hits          577      601      +24     
- Misses         15       20       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson
Copy link
Copy Markdown
Collaborator Author

Maybe instead of static we should use some other term such as:

  • stale
  • fixed
  • constant
  • invariant

other suggestions are welcome.

In any case, I'm happy to make adjustments if we decide on a better term.

Comment thread tests/conftest.py
Note
----
Since the schemas are versioned, fixed schema versions cannot be modified so they are
not returned by this fixture.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I made the schema_uri test cases only visit the uris in latest. This way we don't pick up failures in test_schemas which arise from issues in published schemas.

@schlafly
Copy link
Copy Markdown
Collaborator

We chatted about this on Thursday. I think we thought this was good to go. I'm happy to sign off; anyone else want to weigh in beforehand?

@PaulHuwe
Copy link
Copy Markdown
Collaborator

I am confused - I thought that RTB said they did not want the schemas moved out of latest in the Thursday meeting. I am fine with doing so and the test changes, but I want to keep things in line with their wishes. @tddesjardins @rcosenti-stsci Could one of you clarify?

@schlafly
Copy link
Copy Markdown
Collaborator

My memory of the Thursday discussion---RTB confirmed that they didn't want TVAC / FPS to ever change. They didn't care very much about how we achieved that. I think it's fine to move them out of latest to static.

Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson force-pushed the static_fps_tvac branch 2 times, most recently from c9a402b to bc414f3 Compare June 9, 2025 15:04
@WilliamJamieson WilliamJamieson merged commit f5d233a into spacetelescope:main Jun 9, 2025
13 of 15 checks passed
@WilliamJamieson WilliamJamieson deleted the static_fps_tvac branch June 9, 2025 19:00
@braingram braingram mentioned this pull request Jul 15, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop plan for TVAC and FPS schemas

3 participants