Remove the FPS/TVAC schemas from latest#617
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 97.46% 96.77% -0.69%
==========================================
Files 8 8
Lines 592 621 +29
==========================================
+ Hits 577 601 +24
- Misses 15 20 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adb870e to
734dada
Compare
|
Maybe instead of
other suggestions are welcome. In any case, I'm happy to make adjustments if we decide on a better term. |
| Note | ||
| ---- | ||
| Since the schemas are versioned, fixed schema versions cannot be modified so they are | ||
| not returned by this fixture. |
There was a problem hiding this comment.
Here I made the schema_uri test cases only visit the uris in latest. This way we don't pick up failures in test_schemas which arise from issues in published schemas.
734dada to
1aaff4e
Compare
|
We chatted about this on Thursday. I think we thought this was good to go. I'm happy to sign off; anyone else want to weigh in beforehand? |
|
I am confused - I thought that RTB said they did not want the schemas moved out of latest in the Thursday meeting. I am fine with doing so and the test changes, but I want to keep things in line with their wishes. @tddesjardins @rcosenti-stsci Could one of you clarify? |
|
My memory of the Thursday discussion---RTB confirmed that they didn't want TVAC / FPS to ever change. They didn't care very much about how we achieved that. I think it's fine to move them out of latest to static. |
1aaff4e to
726aff1
Compare
c9a402b to
bc414f3
Compare
bc414f3 to
3c1c757
Compare
Closes #616
This PR removes the FPS and TVAC schemas from the
latestschemas. In addition to this it adds them to a "new" manifeststatic(name can be changed), which denotes that the schemas tagged in it are no-longer going to be updated and will remain as they are. While not strictly necessary (everything will still function), this should become useful if we want to make changes to RDM which partially break handling of the associated static files, in that case we can build a distinct RDM extension which only handles those schemas where we can maintain a minimal functionality for file reads in RDM.Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change