Skip to content

Fix romancal CI job#619

Merged
WilliamJamieson merged 1 commit into
spacetelescope:mainfrom
WilliamJamieson:bugfix/rcal_ci
May 23, 2025
Merged

Fix romancal CI job#619
WilliamJamieson merged 1 commit into
spacetelescope:mainfrom
WilliamJamieson:bugfix/rcal_ci

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Collaborator

Something has changed in romancal which is causing the CI job to fail even though the upstream packages (roman_datamodels and romancal) do not seem to have CI problems. This PR attempts to resolve that issue.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

romancal downstream test works in roman_datamodels which does not invoke xdist
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.34%. Comparing base (9788fbb) to head (d87865a).
⚠️ Report is 141 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files           8        8           
  Lines         566      566           
=======================================
  Hits          551      551           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review May 23, 2025 17:07
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner May 23, 2025 17:07
@WilliamJamieson WilliamJamieson merged commit a99adc6 into spacetelescope:main May 23, 2025
15 of 16 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/rcal_ci branch May 23, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants