Skip to content

Removed category prefix from MSOS archive keywords#674

Merged
WilliamJamieson merged 4 commits into
spacetelescope:mainfrom
cjarnold:msos_20250822
Aug 28, 2025
Merged

Removed category prefix from MSOS archive keywords#674
WilliamJamieson merged 4 commits into
spacetelescope:mainfrom
cjarnold:msos_20250822

Conversation

@cjarnold
Copy link
Copy Markdown
Collaborator

@cjarnold cjarnold commented Aug 22, 2025

This removes the "." prefix for MSOS keyword names to match their archive catalog column counterparts.

CC @scfleming

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@cjarnold cjarnold requested review from a team and WilliamJamieson as code owners August 22, 2025 18:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.76%. Comparing base (ef88402) to head (d944141).
⚠️ Report is 171 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files           8        8           
  Lines         650      650           
=======================================
  Hits          629      629           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@scfleming scfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one minor set of fixes if you don't mind to update a couple spots of "Placeholder" I missed within the msos_observation.yaml.

Comment thread latest/SSC/MSOS/keywords/msos_observation.yaml Outdated
Copy link
Copy Markdown
Contributor

@scfleming scfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a change log fragment.

@WilliamJamieson WilliamJamieson merged commit 0ee0c15 into spacetelescope:main Aug 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants