Skip to content

RAD-219 Update contributors file#682

Merged
WilliamJamieson merged 7 commits into
spacetelescope:mainfrom
WilliamJamieson:docs/contrib
Sep 3, 2025
Merged

RAD-219 Update contributors file#682
WilliamJamieson merged 7 commits into
spacetelescope:mainfrom
WilliamJamieson:docs/contrib

Conversation

@WilliamJamieson

Copy link
Copy Markdown
Collaborator

Resolves RAD-219

Closes #670

Update the contributors file with more detailed instructions for how to contribute to RAD.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov

codecov Bot commented Aug 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (43416f7) to head (b4408d7).
⚠️ Report is 159 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files           8        8           
  Lines         698      698           
=======================================
  Hits          677      677           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this improvement. Just a few minor typos and one rewording.

Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated

@perrygreenfield perrygreenfield left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big improvement. Found one small typo.

Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
@PaulHuwe

Copy link
Copy Markdown
Collaborator

This is a great start. I added a few fixes. I think we should add a small section directing people to the RTD (particularly for the helper script:
https://rad.readthedocs.io/en/latest/helper.html
and creating a schema:
https://rad.readthedocs.io/en/latest/creating.html)

Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
@WilliamJamieson WilliamJamieson force-pushed the docs/contrib branch 2 times, most recently from 0786b02 to 50c45ae Compare August 28, 2025 16:58
@WilliamJamieson WilliamJamieson marked this pull request as ready for review August 28, 2025 17:05
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner August 28, 2025 17:05

@nden nden left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlafly schlafly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks William, this looks good to me.

@nden

nden commented Sep 3, 2025

Copy link
Copy Markdown
Collaborator

@PaulHuwe It looks like all change requests were addressed. Do you mind a second review?

@PaulHuwe PaulHuwe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one tweak

Comment thread CONTRIBUTING.rst Outdated
Co-authored-by: Paul Huwe <42071634+PaulHuwe@users.noreply.github.com>
@WilliamJamieson WilliamJamieson merged commit f28efc8 into spacetelescope:main Sep 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update RAD Contributor Instructions

6 participants