RAD-216: Remove the use of the tagged scalars take 2#688
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #688 +/- ##
==========================================
- Coverage 97.70% 97.48% -0.23%
==========================================
Files 8 8
Lines 698 716 +18
==========================================
+ Hits 682 698 +16
- Misses 16 18 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
73ff27b to
cd3d5a0
Compare
cd3d5a0 to
0ab9311
Compare
1dcf9e9 to
f1f809b
Compare
PaulHuwe
left a comment
There was a problem hiding this comment.
Should the versions of the tagged scalars themselves be incremented? I know it isn't needed functionally, but it makes sense thematically as this is a meaningful change.
|
@WilliamJamieson and @braingram - Lets try to ensure that |
They effectively have a "new" version because they aren't in |
b8d3694 to
3f9e23c
Compare
0a1cb70 to
4104dc1
Compare
692b562 to
04d0e65
Compare
…n-tagged schema cleanly
…_type` keyword which was silently getting wrapped by the product_type tagged scalar. For RDM to stop doing that we need to bump its version to signal the change to it.
04d0e65 to
93a8654
Compare
Resolves RAD-216
Closes #649
Closes #666
This is a second attempt at what #666 was trying to do. This makes no effort to reorganize any schemas nor does it add any new features to RAD.
This makes all the tagged scalars static schemas and removes them from common use. This is based off #687 so that its introduced unit tests could be used to identify all the tags that needed to be moved to static.
Note the changes necessary in RDM and Romancal to make their normal unit tests pass are actually quite small. However, as one can see from the regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/17336765345/job/49224272637. We run into most of the regression tests failing. Looking through the errors they all have the same theme due to type/tag mismatch, I think there are three cases:
TaggedScalarso we get a tag mismatch in the opposite direction.TaggedScalarwrappers in the new output.I am pretty sure that if we regenerate all the data files everything should be fine or possibly run
create_from_modelfrom spacetelescope/roman_datamodels#550 on all the current regression test files save over them with the result.roman_datamodelsPR spacetelescope/roman_datamodels#555romancalPR spacetelescope/romancal#1938Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change