Skip to content

RAD-224: Final cleaning now that internal tags have been removed.#719

Merged
WilliamJamieson merged 6 commits into
spacetelescope:mainfrom
WilliamJamieson:rad_reorg
Oct 3, 2025
Merged

RAD-224: Final cleaning now that internal tags have been removed.#719
WilliamJamieson merged 6 commits into
spacetelescope:mainfrom
WilliamJamieson:rad_reorg

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

RAD-224

This PR addresses the rest of #658 that we decided to do. This moves all the remaining non-datamodels related schemas into sub directories leaving the files left in the latest directory as only pipeline products.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (76af36d) to head (c85d4f5).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   97.50%   97.59%   +0.08%     
==========================================
  Files           8        8              
  Lines         722      747      +25     
==========================================
+ Hits          704      729      +25     
  Misses         18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestions here simplify the tests. It was difficult to follow that latest_datamodel_object meant schema loaded from the top-level latest directory.

Comment thread tests/test_latest.py Outdated
Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py
Comment thread tests/test_latest.py Outdated
@braingram

Copy link
Copy Markdown
Collaborator

Thanks. The changes you pushed look good to me and are much easier to follow.

Would you run the regtests with this PR?

@braingram braingram dismissed their stale review October 3, 2025 14:44

Addressed

@WilliamJamieson WilliamJamieson changed the title Final cleaning now that internal tags have been removed. RAD-224: Final cleaning now that internal tags have been removed. Oct 3, 2025
@WilliamJamieson

Copy link
Copy Markdown
Collaborator Author

@WilliamJamieson

Copy link
Copy Markdown
Collaborator Author

Note I don't think @kdupriestsci or @jbrookens will need to review this as the changes are just shuffling files around and modifying URIs to match.

@braingram braingram left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PaulHuwe PaulHuwe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit a828a37 into spacetelescope:main Oct 3, 2025
17 checks passed
@stscijgbot-rstdms stscijgbot-rstdms mentioned this pull request Oct 3, 2025
@WilliamJamieson WilliamJamieson deleted the rad_reorg branch October 3, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants