RAD-224: Final cleaning now that internal tags have been removed.#719
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 97.50% 97.59% +0.08%
==========================================
Files 8 8
Lines 722 747 +25
==========================================
+ Hits 704 729 +25
Misses 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
braingram
previously requested changes
Oct 3, 2025
braingram
left a comment
Collaborator
There was a problem hiding this comment.
The suggestions here simplify the tests. It was difficult to follow that latest_datamodel_object meant schema loaded from the top-level latest directory.
e9778e7 to
c85d4f5
Compare
Collaborator
|
Thanks. The changes you pushed look good to me and are much easier to follow. Would you run the regtests with this PR? |
Collaborator
Author
Collaborator
Author
|
Note I don't think @kdupriestsci or @jbrookens will need to review this as the changes are just shuffling files around and modifying URIs to match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAD-224
This PR addresses the rest of #658 that we decided to do. This moves all the remaining non-datamodels related schemas into sub directories leaving the files left in the
latestdirectory as only pipeline products.Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change