Skip to content

remove private asdf api usage#742

Merged
PaulHuwe merged 1 commit into
spacetelescope:mainfrom
braingram:fix_asdf_usage
Oct 16, 2025
Merged

remove private asdf api usage#742
PaulHuwe merged 1 commit into
spacetelescope:mainfrom
braingram:fix_asdf_usage

Conversation

@braingram
Copy link
Copy Markdown
Collaborator

@braingram braingram commented Oct 15, 2025

Removes private asdf API usage introduced in #721

Replacing asdf.schema._safe_resolve with public API urldefrag(resolve_uri(...)).

I also added another acceptable remote to the archive.py script which was needed to allow me to test these changes locally.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@braingram braingram marked this pull request as ready for review October 15, 2025 21:18
@braingram braingram requested review from a team and WilliamJamieson as code owners October 15, 2025 21:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.14%. Comparing base (58eb8dd) to head (a465cab).
⚠️ Report is 118 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
- Coverage   97.76%   89.14%   -8.62%     
==========================================
  Files           8       14       +6     
  Lines         759     1013     +254     
==========================================
+ Hits          742      903     +161     
- Misses         17      110      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram requested a review from PaulHuwe October 15, 2025 21:33
@braingram
Copy link
Copy Markdown
Collaborator Author

@PaulHuwe @WilliamJamieson I'd like to get this in before the release so that version isn't using private API.

Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit b0c288b into spacetelescope:main Oct 16, 2025
18 of 20 checks passed
@braingram braingram deleted the fix_asdf_usage branch October 16, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants