Skip to content

RAD-240: Add wfi_parallel#753

Merged
PaulHuwe merged 7 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-240_FIParallel
Dec 16, 2025
Merged

RAD-240: Add wfi_parallel#753
PaulHuwe merged 7 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-240_FIParallel

Conversation

@PaulHuwe
Copy link
Copy Markdown
Collaborator

Resolves RAD-240

Closes #748

This PR add the wfi_parallel keyword block to the observation schema.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (6ab0be9) to head (4353e45).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          14       14           
  Lines        1069     1069           
=======================================
  Hits          918      918           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread latest/meta/observation.yaml
@PaulHuwe PaulHuwe marked this pull request as ready for review December 12, 2025 03:36
@PaulHuwe
Copy link
Copy Markdown
Collaborator Author

@jbrookens Can you review this, please?

@jbrookens
Copy link
Copy Markdown
Collaborator

RAD Archive Diff Report

Generated: 2025-12-16 21:16:05Z

Summary

  • Roman db fields to add: 10
  • Roman db fields to remove: 6
  • Rita db fields to add: 0
  • Rita db fields to remove: 0
  • Destinations with datatype changes: 0

Roman — db fields to add

|fgs_modes_used|basic|GuideWindow|fgs_modes_used|1||meta.basic.fgs_modes_used|
|gsc_id|guide_star|GuideWindow|gsc_id|1||meta.guide_star.gsc_id|
|guide_star_acq_num|basic|GuideWindow|guide_star_acq_num|0||meta.basic.guide_star_acq_num|
|guide_window_id|basic|GuideWindow|guide_window_id|1||meta.basic.guide_window_id|
|guide_window_id|basic|WFIExposure|guide_window_id|1||meta.basic.guide_window_id|
|predicted_dec|guide_star|GuideWindow|predicted_dec|0||meta.guide_star.predicted_dec|
|predicted_ra|guide_star|GuideWindow|predicted_ra|0||meta.guide_star.predicted_ra|
|wfi18_transient|cal_step|ScienceRefData|s_wfi18_transient|1||meta.cal_step.wfi18_transient|
|wfi_parallel|observation|GuideWindow|wfi_parallel|1||meta.observation.wfi_parallel|1
|wfi_parallel|observation|WFIExposure|wfi_parallel|1||meta.observation.wfi_parallel|1

Roman — db fields to remove

|fgs_modes_used|basic|GuideWindow|gw_fgs_modes_used|1||meta.basic.fgs_modes_used|
|gsc_id|guide_star|GuideWindow|gw_gsc_id|1||meta.guide_star.gsc_id|
|guide_star_acq_num|basic|GuideWindow|gw_guide_star_acq_num|0||meta.basic.guide_star_acq_num|
|guide_window_id|basic|GuideWindow|gw_guide_window_id|1||meta.basic.guide_window_id|
|predicted_dec|guide_star|GuideWindow|gw_predicted_dec|0||meta.guide_star.predicted_dec|
|predicted_ra|guide_star|GuideWindow|gw_predicted_ra|0||meta.guide_star.predicted_ra|

Rita — db fields to add

Rita — db fields to remove

Datatype changes by destination

@jbrookens
Copy link
Copy Markdown
Collaborator

jbrookens commented Dec 16, 2025

@avcortese @kdupriestsci See above report.

Relevant changes for this PR:

Roman — db fields to add

|wfi_parallel|observation|GuideWindow|wfi_parallel|1||meta.observation.wfi_parallel|1
|wfi_parallel|observation|WFIExposure|wfi_parallel|1||meta.observation.wfi_parallel|1

Note for the mapping report:

While it's intended to show diffs per PR, it technically shows diffs between this PR version (which includes any previously merged PRs) and the baseline archive. Because of this some of the diffs are from a previous PR (i.e. GuideWindow fields).

@PaulHuwe this one was from #780. It's already merged, but it looks ok to me.

Roman — db fields to add

|wfi18_transient|cal_step|ScienceRefData|s_wfi18_transient|1||meta.cal_step.wfi18_transient|

@PaulHuwe PaulHuwe merged commit ba3f669 into spacetelescope:main Dec 16, 2025
19 checks passed
@PaulHuwe PaulHuwe deleted the RAD-240_FIParallel branch December 16, 2025 22:32
PaulHuwe added a commit that referenced this pull request Dec 17, 2025
@PaulHuwe PaulHuwe restored the RAD-240_FIParallel branch January 12, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLONE - Add wfi_parallel to visit section for B20

5 participants