Skip to content

Fix romancal CI test#774

Merged
WilliamJamieson merged 1 commit into
spacetelescope:mainfrom
WilliamJamieson:fix_romancal_ci
Dec 1, 2025
Merged

Fix romancal CI test#774
WilliamJamieson merged 1 commit into
spacetelescope:mainfrom
WilliamJamieson:fix_romancal_ci

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Collaborator

Currently we are seeing the romancal tests failing, see https://github.com/spacetelescope/rad/actions/runs/19817201686. The failure appears to be due galsim not having a wheel available for Python 3.14, which is the python version those tests are currently being run on. The galsim dependency for romancal comes from romanisim which was added as a romancal dependency by spacetelescope/romancal#2036.

This PR simply runs the romancal tests on Python 3.13 instead of the latest Python, Python 3.14.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

…n galsim. Currently galsim does not have wheels supporting Python 3.14, so we need to test romancal on 3.13 for now.
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (ce9f6df) to head (804f665).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          14       14           
  Lines        1069     1069           
=======================================
  Hits          918      918           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WilliamJamieson
Copy link
Copy Markdown
Collaborator Author

I'm honestly surprised this wasn't an issue earlier, as romancal does not support Python 3.14: https://github.com/spacetelescope/romancal/blob/c9d9845038e39cd841e73fea90e21f0f8e90f8dd/pyproject.toml#L5. It seems to have "run just fine" on 3.14 back before the romanisim change in romancal see: https://github.com/spacetelescope/rad/actions/runs/19226355235/job/54954407998#step:10:137. This run appears to have happened after spacetelescope/romancal#2030 which added a romancal upper python <3.14 pin.

@WilliamJamieson WilliamJamieson merged commit 231dbe3 into spacetelescope:main Dec 1, 2025
24 of 28 checks passed
@WilliamJamieson WilliamJamieson deleted the fix_romancal_ci branch December 1, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants