Skip to content

RAD-243: Remove MA Table Keys from Dark#776

Merged
PaulHuwe merged 2 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-771_DarkMATable
Dec 12, 2025
Merged

RAD-243: Remove MA Table Keys from Dark#776
PaulHuwe merged 2 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-771_DarkMATable

Conversation

@PaulHuwe
Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe commented Dec 7, 2025

Resolves RAD-243

Closes #771

This PR removes the MA Table keywords from the dark current reference schema.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@PaulHuwe PaulHuwe requested review from a team and WilliamJamieson as code owners December 7, 2025 00:54
@PaulHuwe
Copy link
Copy Markdown
Collaborator Author

PaulHuwe commented Dec 7, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (6ab0be9) to head (d22bfd4).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          14       14           
  Lines        1069     1069           
=======================================
  Hits          918      918           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@PaulHuwe PaulHuwe merged commit 17394e8 into spacetelescope:main Dec 12, 2025
19 checks passed
@PaulHuwe PaulHuwe deleted the RAD-771_DarkMATable branch December 12, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify dark reference schema to remove MA Table dependence required meta

3 participants