Skip to content

RAD-245: Detector Status#778

Merged
PaulHuwe merged 4 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-245_DetStatus
Dec 15, 2025
Merged

RAD-245: Detector Status#778
PaulHuwe merged 4 commits into
spacetelescope:mainfrom
PaulHuwe:RAD-245_DetStatus

Conversation

@PaulHuwe
Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe commented Dec 9, 2025

Resolves RAD-245

Closes #768

This PR adds a schema for the Detector Status reference file.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (6ab0be9) to head (b82ce70).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          14       14           
  Lines        1069     1069           
=======================================
  Hits          918      918           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaulHuwe PaulHuwe marked this pull request as ready for review December 9, 2025 01:13
@PaulHuwe PaulHuwe requested review from a team and WilliamJamieson as code owners December 9, 2025 01:13
@PaulHuwe PaulHuwe requested a review from rgcosentino December 9, 2025 01:19
@PaulHuwe
Copy link
Copy Markdown
Collaborator Author

PaulHuwe commented Dec 9, 2025

Matches provided sample file, with no changes. The only request would be for better descriptions.

Comment thread latest/manifests/datamodels.yaml
Comment thread latest/reference_files/detectorstatus.yaml
@PaulHuwe PaulHuwe requested a review from rgcosentino December 9, 2025 18:26
Comment thread latest/reference_files/detectorstatus.yaml
@WilliamJamieson WilliamJamieson mentioned this pull request Dec 11, 2025
8 tasks
@PaulHuwe PaulHuwe merged commit 89d8cc5 into spacetelescope:main Dec 15, 2025
18 of 19 checks passed
@PaulHuwe PaulHuwe deleted the RAD-245_DetStatus branch December 15, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Detector Status reference file

3 participants