Replaced MSOS object catalog with Periodic and Fiducial variants#797
Conversation
| instrume: | ||
| title: Instrument | ||
| description: Instrument used | ||
| type: string | ||
| maxLength: 8 | ||
| archive_catalog: | ||
| datatype: nvarchar(8) | ||
| destination: | ||
| [WFIMSOSReferenceFrame.instrument_name, WFIMSOSCatalog.instrument_name] |
There was a problem hiding this comment.
Being moved to ssc_basic.yaml as "instrument" in #770.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 15 15
Lines 1137 1137
=======================================
Hits 982 982
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The RAD archive diff report shows a lot of changes but they're false-positives so deciding not to include it here. It would be more confusing than necessary. No appreciable differences in this PR. Mostly just a new file type, and a tweak to instrument_name, but that's mostly clean up from another PR. |
|
@ejoliet possible for you to review and approve this week? We are good on SOC side with this, looking to do an intermediate release early next week. Thanks! |
|
I checked that the meta for both variants should be identical (true for now, may change)—LGTM |
MSOS object catalogs come in periodic and fiducial variants and may have slightly different metadata in the future. These already have unique file types in the SSC transfer interface. This PR creates dedicated top level metadata definitions for each type, along with proposed new SOC archive file type names.
This PR also removes instrume keyword from msos_common.yaml as the instrument keyword is being moved to ssc_basic.yaml in #770.
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change