Skip to content

Replaced MSOS object catalog with Periodic and Fiducial variants#797

Merged
PaulHuwe merged 3 commits into
spacetelescope:mainfrom
cjarnold:msos_periodic_fiducial_catalogs
Jan 14, 2026
Merged

Replaced MSOS object catalog with Periodic and Fiducial variants#797
PaulHuwe merged 3 commits into
spacetelescope:mainfrom
cjarnold:msos_periodic_fiducial_catalogs

Conversation

@cjarnold
Copy link
Copy Markdown
Collaborator

MSOS object catalogs come in periodic and fiducial variants and may have slightly different metadata in the future. These already have unique file types in the SSC transfer interface. This PR creates dedicated top level metadata definitions for each type, along with proposed new SOC archive file type names.

This PR also removes instrume keyword from msos_common.yaml as the instrument keyword is being moved to ssc_basic.yaml in #770.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@cjarnold cjarnold requested review from a team and WilliamJamieson as code owners January 13, 2026 18:17
Comment on lines -11 to -19
instrume:
title: Instrument
description: Instrument used
type: string
maxLength: 8
archive_catalog:
datatype: nvarchar(8)
destination:
[WFIMSOSReferenceFrame.instrument_name, WFIMSOSCatalog.instrument_name]
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being moved to ssc_basic.yaml as "instrument" in #770.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.36%. Comparing base (e3247f3) to head (51714e7).
⚠️ Report is 70 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files          15       15           
  Lines        1137     1137           
=======================================
  Hits          982      982           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaulHuwe PaulHuwe requested a review from ejoliet January 13, 2026 19:15
@jbrookens
Copy link
Copy Markdown
Collaborator

The RAD archive diff report shows a lot of changes but they're false-positives so deciding not to include it here. It would be more confusing than necessary. No appreciable differences in this PR. Mostly just a new file type, and a tweak to instrument_name, but that's mostly clean up from another PR.

@scfleming
Copy link
Copy Markdown
Contributor

@ejoliet possible for you to review and approve this week? We are good on SOC side with this, looking to do an intermediate release early next week. Thanks!

@ketozhang
Copy link
Copy Markdown

I checked that the meta for both variants should be identical (true for now, may change)—LGTM

Copy link
Copy Markdown
Contributor

@scfleming scfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit 54c1c1c into spacetelescope:main Jan 14, 2026
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants