Fix bugs in latest testing#807
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #807 +/- ##
==========================================
- Coverage 86.36% 86.32% -0.04%
==========================================
Files 15 15
Lines 1137 1141 +4
==========================================
+ Hits 982 985 +3
- Misses 155 156 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stscieisenhamer
left a comment
There was a problem hiding this comment.
Overall: confirm that everything passes. However, two comments...
Commentary has been left on the originating offensive line in test_latest.py:46. This line still appears to need modification.
WRT the direct_url.json issue: though the tests run when the cwd != <repo_path>, there is a significatnly higher number of SKIPPED tests. When pytest is run in the <repo_path> there are 9 SKIPPED tests. When run from another cwd != <repo_path>, there is 160 SKIPPED tests. Just pointing this out in case this was not intentional.
|
This is expected. If I can't resolve the question of if the install is editable it gives up and assumes that it is not editable. So those tests get skipped. |
7ed04fb to
9ba8ba5
Compare
9ba8ba5 to
7ce673b
Compare
This PR addresses testing issues when the repo is cloned to something other than the name
radand when the unit tests are run from outside the repo.Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change