Skip to content

Fix bugs in latest testing#807

Merged
PaulHuwe merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:bugfix_latest
Jan 21, 2026
Merged

Fix bugs in latest testing#807
PaulHuwe merged 2 commits into
spacetelescope:mainfrom
WilliamJamieson:bugfix_latest

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Collaborator

This PR addresses testing issues when the repo is cloned to something other than the name rad and when the unit tests are run from outside the repo.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.32%. Comparing base (e3247f3) to head (7ce673b).
⚠️ Report is 76 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_latest.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   86.36%   86.32%   -0.04%     
==========================================
  Files          15       15              
  Lines        1137     1141       +4     
==========================================
+ Hits          982      985       +3     
- Misses        155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: confirm that everything passes. However, two comments...

Commentary has been left on the originating offensive line in test_latest.py:46. This line still appears to need modification.

WRT the direct_url.json issue: though the tests run when the cwd != <repo_path>, there is a significatnly higher number of SKIPPED tests. When pytest is run in the <repo_path> there are 9 SKIPPED tests. When run from another cwd != <repo_path>, there is 160 SKIPPED tests. Just pointing this out in case this was not intentional.

Comment thread tests/test_latest.py Outdated
@WilliamJamieson
Copy link
Copy Markdown
Collaborator Author

This is expected. If I can't resolve the question of if the install is editable it gives up and assumes that it is not editable. So those tests get skipped.

@WilliamJamieson WilliamJamieson force-pushed the bugfix_latest branch 2 times, most recently from 7ed04fb to 9ba8ba5 Compare January 21, 2026 19:39
Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulHuwe PaulHuwe merged commit d64b67e into spacetelescope:main Jan 21, 2026
18 of 19 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix_latest branch January 28, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants