When running romanisim on single SCAs it is useful to be able to get the SCA center in sky coordinates given the WFI_CEN to generate appropriate catalogs for each SCA. I wrote some code with pysiaf that I thought should do this and had difficulty debugging it. It turned out I was misunderstanding the position angle arguments between romanisim and pysiaf (the argument to their attitude function). I think the most relevant docs here are
|
pa_aper : float |
|
position angle (North relative to the idealized Y axis) at the aperture |
|
V2Ref/V3Ref |
and
|
--roll ROLL Position angle (North towards YIdl) measured at the V2Ref/V3Ref of the aperture used. (default: 0) |
The former is more informative but the latter is more user-facing and I didn't appreciate what YIdl meant when I saw it at a quick glance. A search for YIdl in the RDox page on coordinate systems doesn't turn anything up either.
I think it would be nice to explain that you are using the idealized frame with a bit more clarity. Maybe an additional note on the "running" documentation page with some explanatory text / link to the RDox page would also be appropriate? I can put together a PR if you'd like.
When running romanisim on single SCAs it is useful to be able to get the SCA center in sky coordinates given the WFI_CEN to generate appropriate catalogs for each SCA. I wrote some code with pysiaf that I thought should do this and had difficulty debugging it. It turned out I was misunderstanding the position angle arguments between romanisim and pysiaf (the argument to their
attitudefunction). I think the most relevant docs here areromanisim/romanisim/wcs.py
Lines 52 to 54 in 42b504c
and
romanisim/docs/romanisim/running.rst
Line 42 in 42b504c
The former is more informative but the latter is more user-facing and I didn't appreciate what YIdl meant when I saw it at a quick glance. A search for YIdl in the RDox page on coordinate systems doesn't turn anything up either.
I think it would be nice to explain that you are using the idealized frame with a bit more clarity. Maybe an additional note on the "running" documentation page with some explanatory text / link to the RDox page would also be appropriate? I can put together a PR if you'd like.