py-setuptools: install setuptools from wheels directly #31131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing setuptools from sources in Spack, we might get into weird failures due to the way we use pip. In particular, for Spack it's necessary to install in a non-isolated pip environment to allow using PYTHONPATH as a selection method for all the build requirements of a Python package. This can fail when installing setuptools since there might be a setuptools version already installed for the Python interpreter being used, with different entry points than the one we want to install. Installing from wheels both pip and setuptools should harden our installation procedure in the context of: - Bootstrapping Python dependencies of Spack - Using external Python packages
This reverts commit 7d96a0a.
alalazo
changed the title
adamjstewart
previously approved these changes
Jun 14, 2022
|
I have another issue to track down, i.e. a system Python 2.7.18 (default, Mar 8 2021, 13:02:45)
[GCC 9.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from sysconfig import get_paths
>>> get_paths()
{'platinclude': '/usr/local/include/python2.7', 'platstdlib': '/usr/lib/python2.7', 'platlib': '/usr/local/lib/python2.7/dist-packages', 'purelib': '/usr/local/lib/python2.7/dist-packages', 'stdlib': '/usr/lib/python2.7', 'scripts': '/usr/local/bin', 'include': '/usr/local/include/python2.7', 'data': '/usr/local'}but then install packages under |
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
adamjstewart
approved these changes
Jun 16, 2022
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
When installing setuptools from sources in Spack, we might get into weird failures due to the way we use pip. In particular, for Spack it's necessary to install in a non-isolated pip environment to allow using PYTHONPATH as a selection method for all the build requirements of a Python package. This can fail when installing setuptools since there might be a setuptools version already installed for the Python interpreter being used, with different entry points than the one we want to install. Installing from wheels both pip and setuptools should harden our installation procedure in the context of: - Bootstrapping Python dependencies of Spack - Using external Python packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing setuptools from sources in Spack, we might get into weird failures due to the way we use pip.
In particular, for Spack it's necessary to install in a non-isolated pip environment to allow using PYTHONPATH as a selection method for all the build requirements of a Python package.
This can fail when installing setuptools since there might be a setuptools version already installed for the Python interpreter being used, with different entry points than the one we want to install. The failure encountered in that case is like the one shown here.
Installing from wheels both
pipandsetuptoolsshould harden our installation procedure in the context of:This PR takes this approach and changes the way we install py-setuptools in Spack.