-
-
Notifications
You must be signed in to change notification settings - Fork 315
fix: robyn builds failing for python v3.13 #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is good to see! Thanks. I wonder if more of the dependencies could be updated? For example jinja2 is now on 3.1.4 and we have 3.0.1 'watchdog == 4.0.1', now 5.0.3 All these still support at least python 3.9 (all but orjson still support 3.8) |
07f28de to
0b766c9
Compare
fixes `poetry install` on Python v3.13 `pytest-codspeed` depends on `cffi` (`v1.15.1` -> `v1.17.0`) `uvloop` (`0.19.0` -> `0.21.0`)
to fix this, we can update since we have #957 down the road, should I move towards migrating to |
let's do this for now |
|
note to self: should also do the migrations from PyO3 v0.20.* to v0.21.* https://pyo3.rs/v0.21.0/migration.html update: please see #1168 |
CodSpeed Performance ReportMerging #1006 will not alter performanceComparing Summary
|
|
@sansyrox PTAL here |
|
Add support for |
sansyrox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @VishnuSanal
Description
This PR fixes #
Summary
This PR does fix robyn builds failing for python v3.13
PR Checklist
Please ensure that:
Pre-Commit Instructions:
notes to self:
PYO3_USE_ABI3_FORWARD_COMPATIBILITY=1 maturin developreferences: