Updated all references of EEPROM.write to EEPROM.update #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch to reduce unnecessary EEPROM writes by using .update() method, which compares the current value. The comparatively small cost of the read should be more than made up for by the reduction in writes for most operations. Also since there is currently no way to read the settings back, it reduces writes where firmware needs to set the OpenLCD to a default state every reset.
|
I had just pulled hardware out to work on this and you've got it done! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to reduce unnecessary EEPROM writes by using .update() method, which compares the current value first. The comparatively small cost of the read should be more than made up for by the reduction in writes for the majority of operations. Also since there is currently no way to read the settings back, it reduces writes where application firmware needs to set the OpenLCD to an initial state at reset.
This resolves issue #16 and has been tested using a Serial connection only.