Fix node command error caused by type: module in package.json

[osbre]

Since the official Laravel starters (Jetstream and Breeze) now have this line in package.json,

laravel/jetstream#1315

"type": "module",

This package no longer works in new Laravel projects because the node command execution results in an error.

The solution would be rename the file to cjs which will indicate that this file runs CommonJS code.

[timvandijck]

@osbre seems like a good fix, thank you for the contribution. Would you pulling the latest version from main into your branch?

[osbre]

Thanks @timvandijck, I've updated the branch

[osbre]

@timvandijck Here is a similar change made to the official Laravel package: laravel/octane#696

[ingLomeland]

@timvandijck any updates on when this can be merged?

[ingLomeland]

maybe even @freekmurze could have a look? its currently broken for Laravel ^10.8 without this change

[freekmurze]

Will this break for people on older Laravel versions?

[ingLomeland]

Will this break for people on older Laravel versions?

Unknown.

[osbre]

Will this break for people on older Laravel versions?

it shouldn't unless they have a reference to vendor/spatie/browsershot/bin/browser.js in any way in the codebase

btw, the tests are failing for unrelated reason and need to be re-run.

[freekmurze]

Thanks!