fix: update scope when content-length changes#1955
fix: update scope when content-length changes#1955RobbeSneyders merged 1 commit intospec-first:mainfrom
Conversation
|
Thanks @mfmarche! You are on to something. It indeed seems like the updated header does not have an effect. However, the scope does need to be copied whenever it is modified in middleware, so the changes in the scope are only propagated downstream. I think the best solution is to update this method to return the modified scope as well. Also, it would be great if you could add a test for this behavior. |
5904dc6 to
2d2c964
Compare
|
Thanks @RobbeSneyders . I took your comments and added appropriate test, and now return the content length. The test prior to the scope change gave a 500, which was similiar to what I saw. |
|
Thanks @mfmarche, the change looks good to me. The pipeline is failing on pre-commit though. You can fix this by running To have it run automatically in the future, you can run |
The actual arg (scope), needs to be updated when the content-length changes. Added test to validate that body changes on setting a default. Signed-off-by: Mike Marchetti <[email protected]>
2d2c964 to
ae44b00
Compare
The actual arg (scope), needs to be updated when the content-length changes.
Fixes #1954
Changes proposed in this pull request: