Document how to install prerequisites in examples READMEs#1993
Document how to install prerequisites in examples READMEs#1993RobbeSneyders merged 1 commit intospec-first:mainfrom
Conversation
|
Please review this draft, if you like this approach I will extend to other README.rst files. If it's not obvious, I'm trying to figure out how to work with you all. Baby steps :) |
|
Thanks @chrisinmtown, this looks good to me. Would be great to extend it to the other examples. |
|
I am extending the changes to all the examples. Please check example Do you have time for this? |
180f06a to
0642103
Compare
|
Let's leave that example as is for now then. Would be great if you could add a notice that it is outdated to the README. For the other examples, the |
I will ask the cloud a few questions and see if I can figure it out :)
I see that Flask is not needed for |
16effac to
37e84aa
Compare
|
This PR has primarily documentation changes. I tweaked one API spec and one requirements file to make the examples work. Please consider. |
37e84aa to
cab9f86
Compare
|
Would you please give me an opinion here? It's a real challenge to contribute when people go silent for a full week at a time. |
cab9f86 to
7ab5867
Compare
7ab5867 to
c5c32d1
Compare
RobbeSneyders
left a comment
There was a problem hiding this comment.
Sorry for the delay @chrisinmtown
Two small comments, then it's good to go for me.
examples/jwt/requirements.txt
Outdated
| @@ -1,3 +1,2 @@ | |||
| ..[swagger-ui] | |||
| python-jose[cryptography] | |||
| Flask>=0.10.1 | |||
There was a problem hiding this comment.
| Flask>=0.10.1 |
There was a problem hiding this comment.
Ok, dropped the Flask line from requirements.txt
| $ python -m venv my-venv | ||
| $ source my-venv/bin/activate | ||
| $ pip install 'connexion[flask,swagger-ui,uvicorn]>=3.1.0' | ||
| $ pip install -r requirements.txt |
There was a problem hiding this comment.
We should remove the flask and connexio dependencies from requirements.txt if we install them directly on the command line.
There was a problem hiding this comment.
Ok, dropped the connexion and Flask lines from requirements.txt
Add server url /openapi to JWT example Add TODO to SQLAlchemy example, does not work with current versions Fixes spec-first#1987
c5c32d1 to
98f0e3c
Compare
You're very welcome |
Add server url /openapi to JWT example
Add TODO to SQLAlchemy example, does not work with current versions
Correct name of module in v3 instructions
Fixes #1987