Return NoContent when mocking HTTP 204 operations

[julienschuermans]

There's never a need to return a response for HTTP 204 - and these code are unlikely to have any "example" response documented in the spec.

Avoids a uvicorn RuntimeError "Response content longer than Content-Length" when mocking a (3.0) spec containing:

...
      responses:
        '204':
          description: No Content
        '401':
          description: Unauthorized
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/ProblemDetails'
...

• We could also move this if/else check into the operation's example_response method. Thoughts?

[coveralls]

coverage: 94.419% (+0.01%) from 94.408%
when pulling 74fb926 on julienschuermans:patch-1
into 087f05f on spec-first:main.

[chrisinmtown]

I guess you'll have to add/extend a test case to cover the newly added lines?

[julienschuermans]

I guess you'll have to add/extend a test case to cover the newly added lines?

I can do that - not sure where to place this though. In test_mock.py, test_mock2.py or test_mock3.py ? I guess we want to test behaviour for both Swagger 2.0 and OpenAPI 3? @RobbeSneyders do you have any input?

[RobbeSneyders]

Thanks @julienschuermans!

I would indeed prefer to move it to the example_response method though.

For the test, I think you can add:

• A swagger test in test_mock.py
• An OpenAPI test in test_mock3.py

It should be quite straight forward if you start from a copy of an existing test.

Don't ask me why the numbering of the test_mock files is as it is 😓

[julienschuermans]

I've moved the code into the example_response implementations and added some tests.
@RobbeSneyders should be good to go?

[chrisinmtown]

I recommend you squash the 13 commits down to a single one.

[Ruwann]

Thanks, @julienschuermans. This one can be merged for me.

We can squash the commits during merging, as we're typically doing a squash and commit.