Update example for latest version of SQLAlchemy#2011
Merged
Ruwann merged 1 commit intospec-first:mainfrom Dec 11, 2024
Merged
Conversation
Contributor
Author
|
@FelixSchwarz please review and comment! |
chrisinmtown
force-pushed
the
update-sqlalchemy-example
branch
from
8430e1a to
2afd62b
Compare
Ruwann
approved these changes
Dec 9, 2024
Member
Ruwann
left a comment
Ruwann
left a comment
There was a problem hiding this comment.
DId a quick check and seems to work fine for me. Tbh, no too familiar with SQLAlchemy but judging from the link and documentation this seems to be the correct way to achieve this. Anything specific you'd like to get a 2nd pair of eyes on to double check?
FelixSchwarz
approved these changes
Dec 9, 2024
Contributor
FelixSchwarz
left a comment
FelixSchwarz
left a comment
There was a problem hiding this comment.
Looks good to me as well. The delete should be fixed, the rest is mostly personal preference.
Pass argument that disables SQLite thread check when creating the engine Revise request-processing functions to use a database session context Drop TODO from the example README
chrisinmtown
force-pushed
the
update-sqlalchemy-example
branch
from
2afd62b to
c3fd66f
Compare
Contributor
Author
|
Thanks @Ruwann and @FelixSchwarz for the comments. New version pushed. |
Ruwann
approved these changes
Dec 11, 2024
Member
Ruwann
left a comment
Ruwann
left a comment
There was a problem hiding this comment.
Thanks, @chrisinmtown and @FelixSchwarz !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass argument that disables SQLite thread check when creating the engine
Revise request-processing functions to work within a database session context
Drop TODO from the example README