Revise exception handling doc on error handler functions#2021
Open
chrisinmtown wants to merge 1 commit intospec-first:mainfrom
Open
Revise exception handling doc on error handler functions#2021chrisinmtown wants to merge 1 commit intospec-first:mainfrom
chrisinmtown wants to merge 1 commit intospec-first:mainfrom
Conversation
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
85de9ab to
45406de
Compare
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
45406de to
c74d411
Compare
chrisinmtown
changed the title
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
2 times, most recently
from
4f80dd1 to
89b902b
Compare
Contributor
Author
|
I scaled back the proposed change based on what I learned from #2026 please try to find time to review. |
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
2 times, most recently
from
dea88bb to
6248d48
Compare
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
6248d48 to
b32847d
Compare
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
b32847d to
1cfdf24
Compare
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
1cfdf24 to
67f4ab4
Compare
Contributor
Author
|
This small documentation change has been open for quite a few months now. I sure would appreciate a comment, thanks in advance. |
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
2 times, most recently
from
5206984 to
6174b2b
Compare
Document that a sync error-handler function is run in a threadpool. Extend the add_error_handler function's Pydoc. Fixes spec-first#2019
chrisinmtown
force-pushed
the
2019-async-exc-handler
branch
from
6174b2b to
bd3e97d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that a sync error-handler function is run in a threadpool.
Extend the
add_error_handlerfunction's PydocFixes #2019